Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build page structure in MDX instead of generating Markdown first #26

Closed
Stvad opened this issue Mar 7, 2021 · 1 comment
Closed

Build page structure in MDX instead of generating Markdown first #26

Stvad opened this issue Mar 7, 2021 · 1 comment

Comments

@Stvad
Copy link
Member

Stvad commented Mar 7, 2021

This is an internal rendering change that should open way for things like:

@Stvad
Copy link
Member Author

Stvad commented Mar 11, 2021

@tombarys @ghansali fyi pushed this out, this may impact CSS customizations used as it changes the structure of the DOM

  • each block now has an id (that matches it’s roam block id)
  • orphan blocks get id with orphan prefix and can be styled based on that
  • html would be now be parsed on a best-effort basis (so you can do iframe/video embeds/etc) - before it was partially escaped/could break the build
  • change to element structure (so css that relied on that closely may need to be changed)
  • added additional wrappers around: block, block content, block-children, and those got corresponding classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant