Environment Inheritance error

[richlove1]

Hi there

Latest update from Taylor includes and extra parameter in Environment.php Make() so now getting the following error:

Runtime Notice: Declaration of BigElephant\Presenter\View\Environment::make() should be compatible with Illuminate\View\Environment::make($view, $data = Array, $mergeData = Array) in /Web/tgc/vendor/bigelephant/presenter/src/BigElephant/Presenter/View/Environment.php line 9

(Still using BigElephant)

Rich

[richlove1]

See: laravel/framework@0192d49

[richlove1]

Possible fix:

     * Get a evaluated view contents for the given view.
     *
     * @param  string  $view
     * @param  array   $data
     * @param  array   $mergeData
     * @return Illuminate\View\View
     */
    public function make($view, $data = array(), $mergeData = array())
    {

        $data = array_merge($data, $mergeData);

        $data = $this->makePresentable($data);

        return parent::make($view, $data);
    }

[kasparasg]

This does the trick, hopefully this will get added to the package soon :)

[robclancy]

Okay on it.

[robclancy]

Can someone confirm this is fixed? I haven't got time to test other than phpunit

[richlove1]

I've not tested extensively but it eradicates the error and follows logic of parent function