Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform syntax check after client generation #49

Open
RobertCraigie opened this issue Aug 20, 2021 · 0 comments
Open

Perform syntax check after client generation #49

RobertCraigie opened this issue Aug 20, 2021 · 0 comments
Labels
kind/improvement An improvement to existing feature and code. level/intermediate priority/low

Comments

@RobertCraigie
Copy link
Owner

RobertCraigie commented Aug 20, 2021 •
edited
Loading

Problem

It is possible that the generator will generate invalid python code leading to the user having to uninstall and reinstall the prisma package

Suggested solution

Either parse the rendered files with an AST parser or import them after generation, if erroneous, remove the rendered files
@RobertCraigie RobertCraigie added the kind/improvement An improvement to existing feature and code. label Aug 21, 2021
@RobertCraigie RobertCraigie changed the title Perform sanity syntax check after client generation Perform syntax check after client generation Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. level/intermediate priority/low
Projects
Prisma Client Python
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RobertCraigie