Add BadStatement case to walk.go to avoid panic #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you rebase to master, I fixed the lint issues @amaicode |
amaicode
force-pushed
the
bad_statement_panic_fix
branch
from
39b5252
to
23f7055
Compare
Just rebased :) |
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Add BadStatement case to walk.go to fix panic if there's bad code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address what I think might have been an oversight in the ast package walk.go file.
When the switch runs across a BadStatement node, this causes it to default (and panic).
I have added an empty case for this node type similar to BadExpression to get around this as well as a unit test.