fix: panic on BadStatement (robertkrimen#495)

Add BadStatement case to walk.go to fix panic if there's bad code.
sg3des · Jul 17, 2023 · 21298ab · 21298ab
1 parent 58bcaf5
commit 21298ab
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/ast/walk.go b/ast/walk.go
@@ -38,6 +38,7 @@ func Walk(v Visitor, n Node) {
 			Walk(v, n.Right)
 		}
 	case *BadExpression:
+	case *BadStatement:
 	case *BinaryExpression:
 		if n != nil {
 			Walk(v, n.Left)

diff --git a/ast/walk_test.go b/ast/walk_test.go
@@ -136,3 +136,22 @@ func Test_issue261(t *testing.T) {
 		})
 	}
 }
+
+func TestBadStatement(t *testing.T) {
+	source := `
+	var abc;
+	break; do {
+	} while(true);
+`
+	program, err := parser.ParseFile(nil, "", source, 0)
+	require.ErrorContains(t, err, "Illegal break statement")
+
+	w := &walker{
+		source: source,
+		seen:   make(map[ast.Node]struct{}),
+	}
+
+	require.NotPanics(t, func() {
+		ast.Walk(w, program)
+	})
+}