Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea regarding the "greeting" message? #3

Closed
rosalieb opened this issue Sep 23, 2022 · 3 comments
Closed

Idea regarding the "greeting" message? #3

rosalieb opened this issue Sep 23, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@rosalieb
Copy link
Contributor

Not an issue but an idea I had when I saw the greeting message "What a beautiful day to run a lake model."!
(oh no, is it the GitHub version of conferences' "I have more of a comment than a question")...

Since it appears that the tool has vocation to be educational too, you could have different greeting messages coming in. To achieve that, you could have a table with as many rows as potential messages. For example:

greet bye
"What a beautiful day to run a lake model." "Have a lovely rest of your day!"
"What is the deepest lake in the world?" "Lake Baikal (5,315 feet [1,620 meters])"

If you define the table above in your script, you could sample in this dataframe a row from the "greet" table to have several messages every time the model is run?
I forked your repo and edited the script to explain the idea if you end up wanting to do that...

Good job, this is a great tool!

@robertladwig
Copy link
Owner

robertladwig commented Sep 23, 2022

I love that idea! Can you do a PR please @rosalieb ?

@robertladwig robertladwig added the enhancement New feature or request label Sep 23, 2022
@rosalieb
Copy link
Contributor Author

Done!

@robertladwig
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants