-
-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux Support #6
Comments
Hi @TheColorRed, |
It works for me on Arch. I did however need to Visual Studio Code does not allow extensions to customize the GUI. But it's a electron app so all the styling just in css. This extension simply patches that css file, a bit hacky, but effective 😏 Running it as a normal user, you will find—in the Developer Tools debug console—the following message:
Visual Studio stores the file that needs to be patched in @robertohuertasm I don't see that there is away around that. Perhaps just a conditionally show a "run as root" message to linux users when they try to activate the command. |
Hi @TheColorRed @rozzzly I've just updated the readme with instructions on how to proceed in Ubuntu. I've just tested and it works. Agree on showing a message to users, both in Windows and Linux. |
Cool! It worked! |
Message is now shown to the users when permission error occurs. |
I went to update to the latest version after the fix and I noticed a few things I would like to note for the record:
note: This is the behaviour for my linux flavor (arch) when installed via
|
Hi @rozzzly, that's right, there's more than a css to be modified. We need to inject some js to make it work and some bak files to rollback in case you want to disable the mod. By changing the ownership of the vscode root folder it's working on Ubuntu. I guess that the danger here, if you don't restore again the old ownership, is that another malicious extension could potentially do anything to your vscode installation. var appDir = path.dirname(require.main.filename);
var base = appDir + (isWin ? '\\vs\\workbench' : '/vs/workbench');
var iconFolder = base + (isWin ? '\\parts\\files\\browser\\media' : '/parts/files/browser/media'); The icons will be downloaded from this repo and extracted to iconFolder. It's ok for me if you want to write some sort of documentation explaining how to proceed on your Linux flavour. I'm thinking that maybe we can use the wiki for that. I've set up the wiki's permissions so that anyone can add and modify pages. Let me know if you have any trouble with it and thanks for your great help! I'm going to reopen this for the moment ;D |
@robertohuertasm I found a better solution to modify the files. Instead of changing the owner of the files, then changing back, I was able to run as sudo with an extra parameter like this:
Just thought that this might be useful for the |
Please, feel free to modify it and submit a PR. I will accept it gladly! ;-) |
Hi |
@robertohuertasm the chown command on arch linux (if vscode was installed from the aur) is: Do you want a PR to put that in the docs? Is it useful or do you assume most arch user's will be able to figure that out on their own :-) |
Hi @codyzu, it's ok for me! 👍 The more information we provide the better for the users 😉 |
It looks like this issue may have come up again with the latest VS Code release 1.3.1. The steps listed worked for me for 1.3.0 but not after the update. Maybe it's related to the Insider's release as well? |
Yes, see #79 |
I'm unable to get this working on Fedora 24. I'm installing VSC with Fedy. Here are the steps I've taken after installing VSC:
At this point, based on the comments left in this and other threads, I should run |
Have you tried to Unless it is different on Fedora. You should be using |
@TheColorRed hmm, not too sure on that - i think i may have been supplying the path to my project with the
|
I've tried to follow your instructions and now the files tree list isn't showing anymore. |
@vhbsouza Please, create a new issue and give us detailed informations. |
@jens1o , thank you man. I just reinstall the extension and the problem was fixed. Thank You anyway! 😄 |
On Ubuntu 16.04, I tried both chowning and following the instructions running as root, and enabling the extension in both cases failed. |
@natejgardner is it a clean install or have you updated? |
@natejgardner I've tested it in Ubuntu 16.04 and it's working. Ensure that you have permissions. Check the readme:
|
It's a clean install on Code 1.5.1. I opened Code, searched for the extension, installed it, followed the additional Linux instructions, hit the enable button, and no icons showed up. I uninstalled and tried this again with the same results. I executed chown, this didn't fix it. I followed the alternative approach, that also didn't fix it. Edit: Nevermind. I got it working. I didn't know that VS Code formally added icons to their settings. Although this icon pack was installed and enabled as an extension, I did not know to go to preferences -> file icon theme -> VSCode Icons |
This doesn't seem to work in Ubuntu.
When I enable the icons nothing happens, then when I disable the icons afterwards, it says they are already disabled.
The text was updated successfully, but these errors were encountered: