This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Removing metrics for queues #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know you've already got a pile of fixes and stuff to release, but I believe that this problem is causing our ostrich thread to OOM. We use a lot of transient queues. :( |
|
I left out create_time from being purged, so this fixes that. Also, i noticed that the ostrich release before the current one works fine as a dep, so I included that. I'm running this version in our infrastructure due to the leaks associated oom'ing things. :( |
|
sorry, i totally lost track of this one. |
|
merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch doesn't seem to work until a newer ostrich is included with Kestrel, but there are a lot of queue metrics hanging around post-deletion in 2.1.5.
I had trouble testing this because I can't seem to get the latest version of Ostrich into Kestrel because one is using 2.9.1 and the other 2.8.1.
I'll just leave this here until it can be applied?