Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing rendering speed #35

Closed
sirpresage opened this issue Mar 2, 2015 · 2 comments
Closed

Increasing rendering speed #35

sirpresage opened this issue Mar 2, 2015 · 2 comments

Comments

@sirpresage
Copy link

Hi, i need an information, i found out that twgantt was getting slower with a large set of events/gantt in one project which is normal. With 100 events, i recorded that the function loadproject was taking 2.8s.

So i searched a bit the reason and i have been able to reduce the execution to 1.7s. What i did is simply comment one line in ganttMaster.js, function loadproject.
//[expand]
//this.gantt.refreshGantt();
(line 390 in my custom version of twgantt)

I did a few test and haven't been able to see a difference in functionnality of twgantt.
Since the expand functionnality is somewhat new, i'm just asking this: is the line i commented really doing something, it seems refreshing is done even without it.

Thanks btw, twgantt is pretty cool, feel free to tell me if i should'nt ask this here, i'm discovering github ;)

@robicch
Copy link
Owner

robicch commented Mar 3, 2015

Hi,
thank you for pointing out this issue.
Yes, you can comment that line.
Actually the refreshGantt() function is called in endTransaction

@robicch
Copy link
Owner

robicch commented Mar 3, 2015

Changes committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants