Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with cross compiling for darwin (serial.go) #48

Closed
stefanpfahler opened this issue Jun 28, 2021 · 3 comments
Closed

Problems with cross compiling for darwin (serial.go) #48

stefanpfahler opened this issue Jun 28, 2021 · 3 comments

Comments

@stefanpfahler
Copy link

Hey robinson,
first of all thank you for this package!

I am currently using your s7 implementation in one of my projects which requires me to cross compile from a linux machine to darwin. I have a lot of pain doing so because of some package importing cgo dependencies, namely "github.com/tarm/serial".
I saw you are using this package inside https://github.com/robinson/gos7/blob/master/serial.go, but the contents of this file aren't used anywhere else in this package and also don't seem to be usable for anyone using gos7.

So my question is: is serial.go crucial for this s7 implementation or could it be removed without causing any hidden errors?

@robinson
Copy link
Owner

Hi Stefan, thanks for a very good question, I am intending to compile it in M1 chip in next few day when I have free time and my concerning is serial port library, and now you got the problem. Actually you can remove serial.go without any isssues.
VG, Robinson

@stefanpfahler
Copy link
Author

Thanks for this quick answer! Okay.. I'll fork your repository then and remove the serial part there.. But I'd prefer depending on your originial repository in the future. Do you plan on removing the serial part some day or maybe implement it without a cgo dependent package?

@robinson
Copy link
Owner

Hi Stefan, more than happy if you could remove it, take some test and build under darwin then make a PR for a branch without serial part. VG, Robinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants