Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md should suggest libiberty-dev as and apt addon package #38

Open
sbosnick opened this issue Apr 15, 2018 · 0 comments
Open

README.md should suggest libiberty-dev as and apt addon package #38

sbosnick opened this issue Apr 15, 2018 · 0 comments

Comments

@sbosnick
Copy link

The example in README.md lists several packages as dependencies of kcov, but does not list "libiberty-dev". The CMake.txt script used to configure the kcov build looks for "libiberty" as a part of finding the "BFD" library (see FindBfd.cmake at line 48).

This manifests as messages in the build log saying that "Could NOT find LIBBFD (missing: LIBBFD_IBERTY_LIBRARY)" when configuring kcov, and "WARNING: kcov has been built without libbfd-dev (or binutils-dev), so the --verify option will not do anything." when cargo coveralls runs kcov.

This is resolved by adding "libiberty-dev" as a package to be installed by the apt addon (see here).

If cargo coveralls requires the "--verify" flag on kcov then the example "travis.yml" file in README.md should list "libiberty-dev" as an apt package in the addon section.

zitsen added a commit to zitsen/rust-htslib that referenced this issue Sep 5, 2018
Error description(see https://travis-ci.org/rust-bio/rust-htslib/builds/424648253):

```
kcov: warning: kcov: WARNING: kcov has been built without libbfd-dev (or
kcov: binutils-dev), so the --verify option will not do anything.
Can't set personality: Operation not permitted
kcov: error: Can't start/attach to /home/travis/build/rust-bio/rust-htslib/target/debug/deps/rust_htslib-b4e39d181972c8d6
Child hasn't stopped: ff00
kcov: error: Can't start/attach to /home/travis/build/rust-bio/rust-htslib/target/debug/deps/rust_htslib-b4e39d181972c8d6
error: test failed
```

Reference: roblabla/cargo-travis#38
johanneskoester pushed a commit to rust-bio/rust-htslib that referenced this issue Sep 12, 2018
* feat: add musl target support

Changes:
- explicitly declare deps for `bzip2` and `lzma` feature.
- add musl target support using `cc` crate.

Though I choose to link native deps with the `bzip2-sys` and `lzma-sys` crates,
note that the deps could be done with cargo's `target` selector.
Let me know if you do not want to link it by default.

/cc #80

* chore: not force install cargo-travis to save time

* fix: try to fix default target error

* fix(CI): fix cargo-travis(kcov) error

Error description(see https://travis-ci.org/rust-bio/rust-htslib/builds/424648253):

```
kcov: warning: kcov: WARNING: kcov has been built without libbfd-dev (or
kcov: binutils-dev), so the --verify option will not do anything.
Can't set personality: Operation not permitted
kcov: error: Can't start/attach to /home/travis/build/rust-bio/rust-htslib/target/debug/deps/rust_htslib-b4e39d181972c8d6
Child hasn't stopped: ff00
kcov: error: Can't start/attach to /home/travis/build/rust-bio/rust-htslib/target/debug/deps/rust_htslib-b4e39d181972c8d6
error: test failed
```

Reference: roblabla/cargo-travis#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant