Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo coverage ignores RUSTFLAGS and build.rustflags #44

Closed
huonw opened this issue Dec 9, 2018 · 1 comment
Closed

cargo coverage ignores RUSTFLAGS and build.rustflags #44

huonw opened this issue Dec 9, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@huonw
Copy link
Contributor

huonw commented Dec 9, 2018

The RUSTFLAGS environment variable and build.rustflags (and target.XYZ.rustflags) configuration key allow passing manual arguments to all rustc invocations in a build. It seems cargo coverage doesn't use them, e.g. RUSTFLAGS=invalid cargo coverage should try to rebuild everything and fail because the argument doesn't make sense.
@huonw huonw mentioned this issue Dec 9, 2018
Closed
@roblabla
Copy link
Owner

roblabla commented Dec 9, 2018 •
edited
Loading

https://github.com/roblabla/cargo-travis/blob/master/src/bin/cargo-coverage.rs#L138 is the culprit. This should probably concat instead of setting unconditionally. PR welcome.

@roblabla roblabla added the good first issue Good for newcomers label Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblabla @huonw