New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPropertyChangedSignal should only allow strings of properties #53

Closed

Validark opened this issue Mar 31, 2019 · 0 comments · Fixed by #66

Contributor

Validark commented Mar 31, 2019 •

edited

Loading

Here is the proper definition I came up with:

type GetProperties<T> = {
	[Key in keyof T]-?: Key extends "GetPropertyChangedSignal"
		? never
		: T[Key] extends RBXScriptSignal
		? never
		: (() => any) extends T[Key]
		? never
		: Key
}[keyof T];

GetPropertyChangedSignal<T extends GetProperties<this>>(property: T): RBXScriptSignal;

Validark mentioned this issue

merge with rbx-safe-types #66

Merged

osyrisrblx closed this as completed in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment