Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul Version requirement seems too strict. #3

Closed
bluefeet opened this issue Sep 21, 2016 · 2 comments
Closed

Consul Version requirement seems too strict. #3

bluefeet opened this issue Sep 21, 2016 · 2 comments

Comments

@bluefeet
Copy link
Contributor

Recently I upgraded my cluster to Consul 0.7.0, and while the API did not change much (a new endpoint was added for transactional kv calls) this module now fails to install. There is no reason this module will not work on 0.7.0.

Seems to me this module is more about supporting the v1 API rather than just a specific version of Consul. Declaring in the docs that it matches the spec of a particular version makes sense, but to wholesale block the install if a very specific version is not installed doesn't make sense to me. And, yes, I could skip the tests, and that is what I've done.
@bluefeet
Copy link
Contributor Author

Ah, I resolved part of this, maybe all of it, in robn/Test-Consul#2. Going to look around the Consul code base to make sure that is true.

@bluefeet
Copy link
Contributor Author

OK, changes made in #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluefeet