Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use submodule for MutatorScale #21

Open
colinmford opened this issue Oct 9, 2023 · 2 comments
Open

Use submodule for MutatorScale #21

colinmford opened this issue Oct 9, 2023 · 2 comments

Comments

@colinmford
Copy link
Contributor

Hi all (@typemytype, @roberto-arista),

In making Transmutor, I noticed there was a standalone repo here on roboDocs for MutatorScale, and a copy of it in this repo... almost. I noticed they diverged only slightly, so I made roboDocs/MutatorScale#4 to update it.

Going forward, I think we should update this repo to use a submodule of MutatorScale, instead of just copying it, like I do on Transmutor.

It works fairly seamlessly except for a few things, the primary thing is that when you clone a repo, by default the submodules aren't cloned as well, you need to add either another argument to your pull or run an extra command, see working with submodules.

Because of this, you need to package things up more neatly for Mechanic and point it to a zip instead of just the repo. I have example of how it's done in a github action. Then you just point it to the latest release

It's a little extra work but I think it would benefit us in the future because there isn't a risk of the different versions of the library diverging further. If you are interested I will make a PR.

@typemytype
Copy link
Contributor

I guess the auto zip download was the reason why that packages was embedded in the ScaleFast. I was unaware of your setup! super neat: action -> release -> downloadable zip url

But before making it more complex: is mutatorScale used outside of ScaleFast?

@colinmford
Copy link
Contributor Author

@typemytype I use it in Transmutor and occasional scripts for making things like tabular figures or monospacing a typeface, so let's count that as 1 and a half uses outside ScaleFast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants