-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmfile hooks being run during helmfile lint
#552
Comments
This is a serious gotcha, I think |
@rajiteh Hey! Thanks for chiming in. I think I have the same sentiment as yours about Maybe you'd better raise a feature request to add |
@patrickmslatteryvt Thanks for reporting this! I think the same comment I made for @rajiteh would apply to your use-case, too. |
Thanks for the insight @mumoshu! I wasn't aware of this. In my helmfile, I had a Also am I correct to assume that running
Yes, will do this. I think it's also better for the documentation to reflect the behaviour of hooks when linting as well.
Update: Just realized that |
@patrickmslatteryvt @mumoshu I have a proposed a PR for the |
Closing this as #580 has been merged. Thanks for your supports @rajiteh @patrickmslatteryvt! |
We implemented helmfile hooks in our helmfiles chart to install cert-manager and the actual install works perfectly. However what does not work is
helmfile lint
against that chart, see below.Ideally the hooks should not run during a lint operation.
helmfiles/v8-deploy.d/012.cert-manager.yaml
Output:
The text was updated successfully, but these errors were encountered: