Fix blank setting and Multilevel FOR indentation #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEBUG: Test name is appearing as Step :(
HelioGuilherme66
added a commit
to HelioGuilherme66/RIDE
that referenced
this pull request
Apr 12, 2023
* Fixed indentation. Still to fix comment/uncomment Undo and Move Up/Down DEBUG: Test name is appearing as Step :( * Use decrease and increase indent on StepController * Some improvements on MoveRowsDown * Improve comment for loops * Improve Deletion of rows and Inserting cells in indented rows * Improve MoveRowsUp * Improve MoveRowsUp, eight tests failing * Improve MoveRowsUp/Down, one test failing * Fix moving FOR loop over other loop. Breaks more tests. * Fix empty setting error. Skip one unit test * Improve tests
HelioGuilherme66
added a commit
that referenced
this pull request
Apr 14, 2023
* Refactor _ContentAssistTextCtrlBase * Refactor _ContentAssistTextCtrlBase * Refactor _ContentAssistTextCtrlBase * Add auto content assist popup * Prevent content assist popup showing when enter key enter * Compatibility for wxPython 4.0.7 * Add configurations * Make publisher errors silent * Make publisher errors silent * Fix typo and unit test * Fix error msg in unit test * Added grid auto suggestion configurations * Creating new resource file should not change the current project default workspace path * Fix publisher msg error when delete variables in tree * Fix publisher msg errors when running cases with DataDriver * Fix click suggestion popup list issues * Fix cannot dismiss suggestions * Add protection for wx lower version * Add protection for wx lower version * Specify wxPython version for MacOS * When user have old RIDE version with config files, this will cause "auto size cols" is activated automatically. * Use context APP, wx.GetApp() could be unstable * updates * Update requirement and setup.py * Update requirement and setup.py * Unlock wxPython version * Update for WX4.1.1 * Update for WX4.1.1 * Update for WX4.1.1 * Remove key binding wx.EVT_MOTION, this will impact the performance * Revert deleted code * Fix issue in windows * Fix issue in windows * Fix runner plugin bug * Update change log * Performance improvements for test suite loading (#2372) * Improve test suite load performance Do not scan subfolders for unknown files and reuse context when loading recursively. * Performance improvements during loading Includes: - Prevent parsing of non-Robot files - Prevent excessive folder traversing on case-insensitive OSs * fix merge mistake * Update CHANGELOG.adoc * Remove workspace cache The dependency with case insensitive operating systems was removed with an incoming merge. Performance still OK. * Changes style hopefully to fix #2379 (#2380) * Grid default colours (#2381) * Changes background and foreground colors to match unknown in Grid * Update README.adoc Change back Travis badges to travis-ci.org * Fix --loglevel option handling (#2382) * Fix --loglevel option handling loglevel should be stored as int for further processing. * Update CHANGELOG.adoc Add info for PR #2382 * Fix broken pipe (#2384) * Fix --loglevel option handling loglevel should be stored as int for further processing. * Change minimum loglevel detection Co-authored-by: J. Foederer <32476108+JFoederer@users.noreply.github.com> * Reverts 'Fix --loglevel option handling #2382' (#2385) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Update README.adoc New info on "support" sites, and python 3.9. * Improve file system changes detection (#2401) * Improve file system changes detection (#2401) (#2402) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Color settings (#2404) * Improve labels colors on Preferences, Windows. WIP * Avoids processing Tree creation when closing app on Windows * Improves Preferences labels visibility on Windows (for example when background is black) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Improve version of JQuery (#2406) * Fix skip keyword #2336 (#2418) * Fix SKIP keyword when Running test * Fix SKIP keyword when Running test (#2419) Update CHANGELOG with fix for #2336 * Update CHANGELOG.adoc * Update README.adoc Versions of Python supported. Changed Travis URL to travis.com and for HelioGuilherme66 fork (because robotframework not working) * Update README.adoc * Fix JSON editor not saving nor validating JSON. (#2426) * Increase dev version * Removed HTML test files, renamed .txt to .robot (#2427) * Cleanup debug * Remove skipped tests * Add SonarCloud badge and Code Coverage analysis * Improve imports in utests * Update versions for Maven runner example, in pom.xml * Text edit no reformat (#2432) * WIP: Add new flag to avoid reformat in Text Editor * More debug on save * Fix missing import * Avoid removing empty cells in Purify * WIP: Add new flag to avoid reformat in Text Editor * More debug on save * Fix missing import * Avoid removing empty cells in Purify * Update tests * Improve dirty state when direct save * Improve autoident in Text Editor * Removes robotframeworklexer because it is included in Pygments * Add colorization to Tasks in Text Editor.Improves # comments. Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Fix #2433 (#2434) * Improves # comment detection. Fixes #2433 * Fix multi level idents (#2444) * Fix some For loop tests * Fixed For loop tests * Fix unit tests * Fixed unit tests, still 3 failing * Fix unit tests. Still two failing * Fixed unit tests :) Finally :) * Improve multilevel Grid colorization * Fix deprecation of node.js 10 breaking Sonarcloud * Add option Reformat to invert current default when Saving * Indentation OK on TextEditor. Still Unit tests failing * Add detection of separating spaces count. Two utests Failing * Fix two unit tests, by improving section detection and using two spaces by default. * Adds documentation for: IF, ELSE, ELSEIF, WHILE, TRY, EXCEPT, BREAK, CONTINUE * Improve documentation for FOR, IF, ... TRY/EXCEPT * Fix EMPTY comments lines * Movement rows, OK. Colorization in FOR step with assignement, not OK. * Better info for indented cells. Two tests failing. (#2445) * Better info for indented cells. Two tests failing. * Fix FOR help and coloring. * Change to editor after getting a suggestion.Fixes #2292 (#2446) * Simple fixes (#2447) * Clean code * Clean code * Fixes Sort Tests and Variables. Disables selection ot item when right-click in Project tree * Keep HTML Test Suites format available to open (#2448) * Fix arguments (#2453) * Fix arguments to use spaces in paths. WIP * WIP: parser is OK on Runner, but needs to fix error detection on Plugin * Fix arguments to use spaces in paths. Needs to be tested on Windows * Some Windows changes * Better but not 100% * Working with files and quoted variables. Red color warning still * Fix encoding in Windows. * Fix for Linux * Fixed parsing commands in Linux (hopefully in MacOS too) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Update README.adoc Warn about failing to run tests when stated from Desktop Shortcut * Fix starting from shortcut on Windows (#2455) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Update README.adoc removed broken info * Change testing to pytest and remove nose testing (#2457) * WIP: Debugging from fix_arguments * Fix commenting single lines. Still problems on blocks * Fixed indentation. Still to fix comment/uncomment Undo and Move Up/Down * DEBUG: Test name is appearing as Step :( * Change unit test tool to pytest and remove nose dependency. Support for Python 3.10 at unit test level. * Fix invalid empty setting and invalid test suite with line comment (#2458) Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Fix unit tests (#2459) * Fix invalid empty setting and invalid test suite with line comment * Fixes two unit tests Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Fix blank setting and Multilevel FOR indentation (#2462) * Fixed indentation. Still to fix comment/uncomment Undo and Move Up/Down DEBUG: Test name is appearing as Step :( * Use decrease and increase indent on StepController * Some improvements on MoveRowsDown * Improve comment for loops * Improve Deletion of rows and Inserting cells in indented rows * Improve MoveRowsUp * Improve MoveRowsUp, eight tests failing * Improve MoveRowsUp/Down, one test failing * Fix moving FOR loop over other loop. Breaks more tests. * Fix empty setting error. Skip one unit test * Improve tests * Fix line comments (#2467) * Fix invalid empty setting and invalid test suite with line comment * Improve line comment detection. Change default spaces to 2 and then adjust. * Refactor FOR (#2468) * Fix invalid empty setting and invalid test suite with line comment * Remove ForLoop calls. WIP 25 utest failing * Remove ForLoop calls. WIP 5 utest failing * Fix FOR move up. WIP not totally OK. Two utest failing. * Fix FOR move up. WIP not totally OK. Two utest failing. * Debug assign in FOR. WIP not totally OK. Two utest failing. * Improve loop variable detection. WIP. Breaks Set * Variable * Improve variables detection in FOR and Set (*) Variable * Improves var detection, but degrades coloring performance * Especial cases for Comment. WIP * Still 3 tests failing. CellInfo * Final fix for IN ENUMERATE Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Fix commented cells info (make all OPTIONAL) (#2469) * Add multiline comment and uncomment to Text Editor (#2470) * Allow to edit resource files (#2471) * Remove deprecated code in TestRunner * Adds support to open and edit resource files * Fix directories open and BuiltIn.Comment processing (#2472) * Fix opening directories and variables without suggestions * Add BuiltIn.Comment to comment/uncomment processing * Fix wxPython 4.2.0 (#2475) * Remove inheritance of RIDEDialog * Fix for wxPython 4.2.0 Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> * Console Colors and Skip in progress bar (#2476) * Fix console width to fit visible area. Fixes #2320 * Add color parsing for console log * Add use_color and colors to TestRunner Preferences. Add skip counter to progress bar. WIP * Fix list and dictionary editors. (#2479) * Corrects the option for --consolecolors on Windows * DEBUG list and dict variables editor. Can create but not Edit * Fix list and dictionary editors. * Add Skip counter and corresponding colored icon to Project tree (#2480) * Set default language to en_US * Add skip counter and colored icon to project tree * Changelog is now on disk with access from menu (#2481) * Add offline change log * Add release notes and changelog links to UpdateNotifier. Error check on Text Editor * Fix offline change log (#2484) * Fix missing menu icons in Linux (#2485) * Fix menu icons in Linux (finally)! * Change tree (#2486) * disable item selection WIP * Fix menu icons in Linux (finally)! * Avoid AssertionError when monitoring files or directories with multibyte names, like Chinese chars * Fix save status in Text Editor no need to double Ctrl-S * Improves Undo in Text Edit * fix enclosing symbols * fix list * Disable closing Test Suites panel (#2500) * Add CONTRIBUTING.adoc (#2493) * Created a contribution doc trying... * Delete CONTRIBUTIONS.adoc * did some changes * Update CONTRIBUTION.adoc did the required changes * Update CONTRIBUTION.adoc Removed incorrect text, from Robot Framework, and added commands to start and debug RIDE. * Update CONTRIBUTION.adoc Final changes to document. Co-authored-by: Hélio Guilherme <helioxentric@gmail.com> * Rename CONTRIBUTION.adoc to CONTRIBUTING.adoc * fix bug #2361 (#2494) * fix bug #2361 Chinese name of test case can not display correct on console log * Use ANSICP instead of OEMCP * set PYTHONIOENCODING to UTF-8 when running RF * Fix for diacritic characters display on RIDE console (#2502) * Add files via upload * Update testrunnerplugin.py * Update testrunnerplugin.py * Fix docs #2435 (#2505) * Debugging #2435, still not fixed * Hide items in Test Suite explorer with names starting with # * Add support for content before sections in .robot and .resource files * Restore documentation setter * Fix missing comments on Library and Resources imports (#2506) * Small update to CONTRIBUTING.adoc and editor updates for enhancement 2508 (#2510) * Small update to CONTRIBUTING.adoc * Updates for enh 2508 * Doc change * Changes to allow multiline comment and uncomment in Text Editor. Documentation update. Still missing unit tests, and fix Grid Editor. Co-authored-by: Helio Guilherme <helioxentric@gmail.com> * Fix uncomment (#2511) * Fix multivariable assign comment and uncomment. DEBUG get_assign and Undo. WIP * Fix comment/uncomment steps with two or more variables assignement * Update CHANGELOG.adoc * Update version and offline CHANGELOG * Simplify some code in datarow * Attempt to improve performance. * Add cells in Step for direct access * Remove slow code in model.Step.as_list * Update CHANGELOG.adoc * Grid updates for #2512 * Fix MoveCursorDown to use Grid method. * Attempt to improve performance. * Remove repeated actions on kweditor * Version 2.0b3 * Work in progress fix keys shortcuts * Revert some keyboard shortcuts * Ommit empty line when writing sections * Update README.adoc * Create sonarcloud.yml * Update sonarcloud.yml * Update sonarcloud.yml * Add gitactions build and update tox and sonar * Update CI tasks * Update Sonar definitions * Update Sonar definitions * Update APPVeyor definitions * Update tox for old python versions * DevOps actions (#2520) * Create sonarcloud.yml * Update sonarcloud.yml * Update sonarcloud.yml * Add gitactions build and update tox and sonar * Update CI tasks * Update Sonar definitions * Update Sonar definitions * Update APPVeyor definitions * Update README.adoc * Update tox for old python versions * Fix uncomment in Text Editor (#2529) ** Fix comments in steps with arguments * Improve uncomment in Text Editor * Fix comments (#2530) * Update appveyor python versions * Experience with appveyor configuration * Experience with appveyor configuration 2 * Experience with appveyor configuration 3 * Experience with appveyor configuration 4 * Experience with appveyor configuration 5 * Update appveyor python versions * WIP: compute args in Step.as_list() * Fix comments in steps with arguments * Fix problems in Grid Editor on keywords with steps with #comments * Revert version number * Note about updating from current development 2.0rc1 * Devops (#2531) * Update appveyor python versions * Try to test in macos * Change to allow building in this branch * Use python3.9 * Install python3.9 and try to get information about system * Install pytest * Change to use invoke test * Update .appveyor.yml commented path definition * Texteditor ctrl i (#2522) * Add Ctrl-I to Text Editor * Insert multiselected rows * Improve multiline insert and cursor position --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Devops (#2533) * Use python 3.10 * Use python 3.10, debug * Use python 3.10. Change to Bigsur * Use python 3.8 with Bigsur * Try to remove architecture in Bigsur * Change to build on image Visual Studio 2022 * Change path to python * Change how to call invoke * Add python to PATH * Exclude test on Windows * Hide Linux badges * Add install of wxPython (#2534) * Add Ctrl-D to Text Editor (#2523) * CTRL-D + author surname * Fix uncomment in Text Editor (#2529) ** Fix comments in steps with arguments * Improve uncomment in Text Editor * Fix comments (#2530) * Update appveyor python versions * Experience with appveyor configuration * Experience with appveyor configuration 2 * Experience with appveyor configuration 3 * Experience with appveyor configuration 4 * Experience with appveyor configuration 5 * Update appveyor python versions * WIP: compute args in Step.as_list() * Fix comments in steps with arguments * Fix problems in Grid Editor on keywords with steps with #comments * Revert version number * Note about updating from current development 2.0rc1 * Devops (#2531) * Update appveyor python versions * Try to test in macos * Change to allow building in this branch * Use python3.9 * Install python3.9 and try to get information about system * Install pytest * Change to use invoke test * Update .appveyor.yml commented path definition * Texteditor ctrl i (#2522) * Add Ctrl-I to Text Editor * Insert multiselected rows * Improve multiline insert and cursor position --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Improve Ctrl-D function in Text Editor * Update CHANGELOG --------- Co-authored-by: Hélio Guilherme <helioxentric@gmail.com> * Update Git Actions (#2536) * fix install of wxPython * fix install of wxPython after tox * Remove use of tox and add invoke test * Install missing library * Install another missing library * Run Xvfb * Move step Run Xvfb * Add DISPLAY to env * Install xorg * Update ubuntu * Skips tests with wxPython when not having DISPLAY * Exclude two more test for missing DISPLAY * Git actions add pylint (#2537) * Create pylint.yml Lets see how this works ;) * Add .pylintrc * Change to analyse src only * Texteditor move row (#2538) * Alt-Down * Alt-Up * Fix uncomment in Text Editor (#2529) ** Fix comments in steps with arguments * Improve uncomment in Text Editor * Fix comments (#2530) * Update appveyor python versions * Experience with appveyor configuration * Experience with appveyor configuration 2 * Experience with appveyor configuration 3 * Experience with appveyor configuration 4 * Experience with appveyor configuration 5 * Update appveyor python versions * WIP: compute args in Step.as_list() * Fix comments in steps with arguments * Fix problems in Grid Editor on keywords with steps with #comments * Revert version number * Note about updating from current development 2.0rc1 * Devops (#2531) * Update appveyor python versions * Try to test in macos * Change to allow building in this branch * Use python3.9 * Install python3.9 and try to get information about system * Install pytest * Change to use invoke test * Update .appveyor.yml commented path definition * Texteditor ctrl i (#2522) * Add Ctrl-I to Text Editor * Insert multiselected rows * Improve multiline insert and cursor position --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Devops (#2533) * Use python 3.10 * Use python 3.10, debug * Use python 3.10. Change to Bigsur * Use python 3.8 with Bigsur * Try to remove architecture in Bigsur * Change to build on image Visual Studio 2022 * Change path to python * Change how to call invoke * Add python to PATH * Exclude test on Windows * Hide Linux badges * Add install of wxPython (#2534) * Add Ctrl-D to Text Editor (#2523) * CTRL-D + author surname * Fix uncomment in Text Editor (#2529) ** Fix comments in steps with arguments * Improve uncomment in Text Editor * Fix comments (#2530) * Update appveyor python versions * Experience with appveyor configuration * Experience with appveyor configuration 2 * Experience with appveyor configuration 3 * Experience with appveyor configuration 4 * Experience with appveyor configuration 5 * Update appveyor python versions * WIP: compute args in Step.as_list() * Fix comments in steps with arguments * Fix problems in Grid Editor on keywords with steps with #comments * Revert version number * Note about updating from current development 2.0rc1 * Devops (#2531) * Update appveyor python versions * Try to test in macos * Change to allow building in this branch * Use python3.9 * Install python3.9 and try to get information about system * Install pytest * Change to use invoke test * Update .appveyor.yml commented path definition * Texteditor ctrl i (#2522) * Add Ctrl-I to Text Editor * Insert multiselected rows * Improve multiline insert and cursor position --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Improve Ctrl-D function in Text Editor * Update CHANGELOG --------- Co-authored-by: Hélio Guilherme <helioxentric@gmail.com> * Update Git Actions (#2536) * fix install of wxPython * fix install of wxPython after tox * Remove use of tox and add invoke test * Install missing library * Install another missing library * Run Xvfb * Move step Run Xvfb * Add DISPLAY to env * Install xorg * Update ubuntu * Skips tests with wxPython when not having DISPLAY * Exclude two more test for missing DISPLAY * Git actions add pylint (#2537) * Create pylint.yml Lets see how this works ;) * Add .pylintrc * Change to analyse src only * Update CHANGELOG and add TODO --------- Co-authored-by: Harm Kramer <harm.kramer@gmail.com> * Ctrl-Shift-I - insert cell(s) (#2528) * Ctrl-Shift-I * Ctrl-Shift-I * Completion of Ctrl-Shift-I in Text Editor --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Texteditor ctrl shift d - delete cells (#2541) * Ctrl-Shift-I * Ctrl-Shift-I * Completion of Ctrl-Shift-I in Text Editor * Delete cells * Fix CTRL-SHIFT-D detection --------- Co-authored-by: HelioGuilherme66 <helioxentric@gmail.com> * Comments section (#2544) * Initial debug. Comment now shows in Text Edit bust with newlines * More debug * Pre release (#2545) * Initial debug. Comment now shows in Text Edit bust with newlines * More debug * Update tool and release notes. Add missing RETURN doc * Update offline CHANGELOG * Restore stashed code * Update off-line changelog * Version 2.0rc1 * Change to development version * Version 2.0 * Cleaning (#2556) * Reduce warnings in utest * Dev version * Improvecode (#2558) * Version in Appveyor * Improve coverage test report * Fix code bug detected by Sonar * Fix coverage.xml location in sonar configuration * Code cleaning with suggestions from PyCharm and Sonar * Improve coverage reporting * Improve quality of code in Text Editor * Improve code with suggestions from Sonar * Set pythonpath if not set * Recover adding newlines in sections (#2563) * Reduce pylint python versions, add sonar-scanner download and install (#2564) * Reduce pylint python versions, add sonar-scanner download and install * Change installation way of sonar-scanner * Fix installation way of sonar-scanner * Change test-ci to not run sonar and create new sonar task * Improves color management in Panels and Help/Doc popups (#2566) * Fix using defined color in help and HTML content * Fix persistance of color settings in File Explorer and Project Tree * Fixes not clearing fixtures, and synchronizing in Text Editor (#2567) * Fix vulnerabilities identified by Snyk (#2568) * Improve saving in texteditor (#2571) * Improve code in TextEditor * Fix modification indication after saving on Text Editor * Unit tests for Textedit (#2572) * Update appveyor python versions * Experience with appveyor configuration 2 * WIP: unit tests for Text Editor * Improve app creation and avoid AttributeError * Add unit tests for Text Editor * Fix missing color editor for keywords in Text Editor (#2573) * Cleanup code in kweditor (#2574) * Revert change that is causing error messages (#2575) * Merge PR code for autocomplete by Johnny H * DEBUG enclosing text * Fix auto-enclosing in Cell Editor in Linux --------- Co-authored-by: Johnny Huang <jnhuang@telenavsoftware.com> Co-authored-by: Johnny.H <jnhyperion@gmail.com> Co-authored-by: J. Foederer <32476108+JFoederer@users.noreply.github.com> Co-authored-by: Helio Guilherme <helio.guilherme@load.digital> Co-authored-by: space monkey <113308290+sofezticated-gentleman@users.noreply.github.com> Co-authored-by: Junling Zhu <jl.zhu@tom.com> Co-authored-by: Harm <harm.kramer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.