Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI #1768

Closed
guykisel opened this issue Aug 8, 2014 · 7 comments
Closed

Set up CI #1768

guykisel opened this issue Aug 8, 2014 · 7 comments

Comments

@guykisel
Copy link
Contributor

guykisel commented Aug 8, 2014

You can pretty easily set up a job that will automatically run tests against every commit and every pull request. I can help with this if there's interest.

For example, see https://travis-ci.org/guykisel/robotframework-faker

@pekkaklarck
Copy link
Member

We actually already have CI set up at http://robot.radiaatto.ri.fi but it hasn't been updated yet to track GitHub repository. It runs tests on Python 2.5-2.7, Jython 2.5 and IronPython 2.7, both on Linux and Windows. If we get same platform support elsewhere, I'd be happy to swtich. Otherwise we just need to reconfigure old service and also add a note about it to README and/or other docs. Definitely a must for 2.8.6.

@pekkaklarck pekkaklarck added this to the 2.8.6 milestone Aug 8, 2014
@pekkaklarck pekkaklarck changed the title Set up Travis CI test job Set up CI Aug 8, 2014
@guykisel
Copy link
Contributor Author

guykisel commented Aug 8, 2014

Oh, cool, I never saw this. Jenkins has the capability to build GitHub pull requests, too, though it requires a plugin. https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin

@guykisel
Copy link
Contributor Author

guykisel commented Aug 8, 2014

I think Travis is capable of running IronPython and Jython if configured properly, but if you already have Jenkins set up then I don't see a good reason to switch.

Example Travis config with IronPython: https://github.com/earthreader/libearth/blob/master/.travis.yml

@guykisel
Copy link
Contributor Author

Turns out Travis phased out support for Python 2.5, so Jython testing isn't really possible. I suggest sticking with the existing Jenkins setup.

@jussimalinen
Copy link
Member

I just updated the jobs to poll now the github project. So that should work.

I will next take a look at getting the automatic pullrequest testing to work. (Or semiautomatic, we need to manually check the pull request before accepting it to run on the CI machine of course.)

@jussimalinen
Copy link
Member

Now there is an almost automatic build for pull requests. We still need figure where to document the ci. Probably to contribution instructions.

@pekkaklarck
Copy link
Member

I agree that CONTRIBUTING.rst is the best place to write information about CI, but the problem is that we don't yet have it. I think this is what we should do:

  • Document CI here. Its location is already mentioned above, but we should explain how running PRs works.
  • Add an issue about writing contribution guidelines and refer this issue from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants