Improve BuiltIn.Evaluate error messages

[guykisel]

For issue #1795 - improve error messages for empty/nonstring expressions

[robotci]

Admin, can CI be enabled?

[guykisel]

@pekkaklarck I changed this because an unspecified except: is generally avoided in Python, but I'm not completely sure if it was intentional in this case.

[pekkaklarck]

Yes, using except: here and in many other places in Robot code base is intentional. The reason is that Java based exceptions are not based on Exception and thus go through except Exception:. The problem with plain except: is that it catches also SystemExit and KeyboardInterrupt, but this is handled by utils.get_error_message/details that reraises them and that ought to be used everywhere where plain except: is used.

[guykisel]

Thanks for the explanation. I'll change it back.

[guykisel]

Does this work for non-admin users?

@robotci: once

[pekkaklarck]

@guykisel: Nope, only admins can control CI. Would be too big security risk to allow anyone to run any code there. But we can whitelist you so that your pull-requests ought to be run automatically. Let's see does this work:

@robotci: whitelist user

[robotci]

Tests passed.

Refer to this link for build results (access rights to CI server needed):
http://robot.radiaatto.ri.fi/job/RobotFramework-pull-requests/3/

[guykisel]

@robotci: once

[robotci]

Tests passed.

Refer to this link for build results (access rights to CI server needed):
http://robot.radiaatto.ri.fi/job/RobotFramework-pull-requests/4/

[pekkaklarck]

@guykisel: I think you don't need to explicitly tell CI to run tests now that you are whitelisted. All your PRs ought to be run automatically.

Or how was it @jussimalinen? Also, what was the method to avoid running tests if there is no need? We definitely need to list all commands somewhere. CONTRIBUTING.rst is probably the best place once we have written it, and until that listing them in a comment to #1768 is probably the easiest solution.