-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution instructions #1805
Comments
We should explain there how the pull request builder works on CI. When a new pull request comes in, the CI will ask if one of the admins can verify the pull request. The admins are currently me and Pekka. The commands are: The commands can be anywhere on the comment. Adding the skip statement ([skip ci], with the square brackets) to the pull request body will cause the job not to run. |
More about the ci on #1768 |
At some point it was mentioned that there should be a contributor license agreement. Maybe you already knew about this, but I just learned that Github has a service for doing this: https://www.clahub.com/ |
We are creating alpha 2 today. After that getting contribution guidelines released is my highest priority. |
...and now moving to rc1.. |
I've merged PR #1805 by @guykisel and enhanced the initial guidelines considerably afterwards. Review by @jussimalinen, @guykisel and everyone else would be great. As a non-native English writer comments about used language are highly appreciated. Comments can be added to the individual commits or left here, and with larger changes PRs are probably the best approach. I plan to proofread this myself once more before making RF 2.9 rc 1 tomorrow. Documentation changes are possible also after it. |
Looks pretty good! The enhancements are very helpful. Left a few comments on one of the commits with minor typo fixes. |
Thanks a lot for the review @guykisel! Fixed the issues you found and also enhanced guidelines a little afterwards. I think this issue can be considered done. That obviously doesn't mean we couldn't enhance the guidelines in the future. |
Thank for the work guys! |
We should have CONTRIBUTING.md or similar instructing on how to contribute to the project.
The text was updated successfully, but these errors were encountered: