Tidy rows longer than 80 chars to separate rows in plain text files #1894
Conversation
|
Tests passed. Refer to this link for build results (access rights to CI server needed): |
|
Thanks for the pull request! The idea seems very good, but when discussing this with @pekkaklarck we thought this probably be configurable from the command line.. We cant take this into 2.8.7 anymore (planning release for Tomorrow), but lets look at this for 2.9. |
|
Sure, sounds good. |
Conflicts: src/robot/writer/rowsplitter.py
|
Note this is a work in progress as I update this PR to reflect the latest changes in master and also try to make this configurable from the command line. |
|
Tests FAILED! Refer to this link for build results (access rights to CI server needed): |
|
Tests FAILED! Refer to this link for build results (access rights to CI server needed): |
|
Sorry for not looking at this PR earlier. What's the current status? |
|
Haven't looked at this in a few weeks. Making it configurable from the command line is a bit difficult due to how deeply nested the rowsplitter is. I need to spend more time looking at the structure of the relevant code and thinking about it. |
|
Yeah, the related code seems to be a bit too clever. Let me know if you want to discuss it e.g. on IRC some day. Before a major release we can do even larger refactoring if needed. |
|
Sure, that could be good. My schedule is a bit uncertain for the next few weeks, so I might not be able to have a live discussion for a while. I don't think this is a high priority enhancement, since I doubt Tidy is heavily used. |
|
I would like to work on this. May I pick it up if it is not being worked on? |
|
Please go ahead! |
|
there was PR#2771 which has been closed last week since nobody reviewed it. |
|
Tidy has been totally rewritten as part of RF 3.2 parser rewrite and there is not way this PR could anymore be merged. Good news is that the new Tidy is a lot better to enhance if needed. |
#1891
I would prefer to make the max length a Tidy command line option, but I would have to make a lot of changes to pass that value all the way down to
rowsplitter. It seems a lot simpler to just set a max character count inTxtFormatterand pass that intorowsplitter. I would also prefer to pass the column separator intorowsplitterfor use in calculating the row length, but there doesn't seem to be a simple way to do that in the current structure. Assuming the separator is four spaces seems to work well enough.