Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namespace finder and service validation checker #79

Merged
merged 3 commits into from
Mar 2, 2015

Conversation

dwlee
Copy link
Contributor

@dwlee dwlee commented Mar 2, 2015

@@ -36,6 +36,26 @@
##############################################################################


def is_valid_service(service_name):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_valid_service is confusing...that assumes it is available AND not bad/corrupt.

is_available or service_is_available would be less confusing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service_is_available

@jihoonl
Copy link
Collaborator

jihoonl commented Mar 2, 2015

👍

jihoonl added a commit that referenced this pull request Mar 2, 2015
Update namespace finder and service validation checker
@jihoonl jihoonl merged commit 1691a62 into indigo Mar 2, 2015
@jihoonl jihoonl deleted the slow_connection_patch branch March 2, 2015 09:48
@jihoonl jihoonl restored the slow_connection_patch branch March 2, 2015 10:06
@jihoonl jihoonl deleted the slow_connection_patch branch March 2, 2015 10:10
@jihoonl
Copy link
Collaborator

jihoonl commented Mar 2, 2015

I am changing the logic of find_namespace by following.

  • renaming find_namespace to find_service_namespace - To be precise, it finds namespace for ros service. We may develop find_topic_namespace later.
  • provide unique argument just as find_service and returns multiple namespaces - it is easier to handle code flow.
  • service_type argument as optional - We may want to find namespace without type.

jihoonl added a commit that referenced this pull request Mar 2, 2015
@jihoonl
Copy link
Collaborator

jihoonl commented Mar 2, 2015

@stonier, @dwlee FYI

jihoonl added a commit that referenced this pull request Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants