-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update namespace finder and service validation checker #79
Conversation
@@ -36,6 +36,26 @@ | |||
############################################################################## | |||
|
|||
|
|||
def is_valid_service(service_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_valid_service
is confusing...that assumes it is available AND not bad/corrupt.
is_available
or service_is_available
would be less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service_is_available
👍 |
Update namespace finder and service validation checker
I am changing the logic of find_namespace by following.
|
To solve following issue
https://github.com/robotics-in-concert/rocon_tools/blob/indigo/rocon_python_comms/src/rocon_python_comms/services.py#L48
related PR
robotics-in-concert/rocon_qt_gui#182