New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper threads join on termination #36

Open

m3d opened this issue Dec 5, 2017 · 1 comment

Member

m3d commented Dec 5, 2017

At the moment some threads are killed before proper termination - join() with timeout is necessary. Related to #34

Member

zbynekwinkler commented Sep 26, 2019

From reading https://docs.python.org/3/library/threading.html?#thread-objects :

Note

Daemon threads are abruptly stopped at shutdown. Their resources (such as open files, database transactions, etc.) may not be released properly. If you want your threads to stop gracefully, make them non-daemonic and use a suitable signalling mechanism such as an Event.

We need to convert all threads to regular, non-daemon, threads to implement a correct shutdown (see also #115).

https://github.com/robotika/osgar/search?q=daemon&unscoped_q=daemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment