Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interface to control PID gain values #60

Closed
francesco-romano opened this issue Feb 13, 2014 · 4 comments
Closed

Implement interface to control PID gain values #60

francesco-romano opened this issue Feb 13, 2014 · 4 comments

Comments

@francesco-romano
Copy link
Collaborator

We must implement the PID interface (or how it is named in yarp), so the pid gain values are exposed also on the robotMotorGui

@barbalberto

@francesco-romano
Copy link
Collaborator Author

I think this is no longer needed? @traversaro ?

@traversaro
Copy link
Member

No, we still need this.

@traversaro
Copy link
Member

For implementing IPidControl you have to implement the functions for which we now just have a stub returning false here: https://github.com/robotology/gazebo-yarp-plugins/blob/master/plugins/controlboard/src/ControlBoardDriverPidControl.cpp .

For seeing how the PID gains are loaded at plugin startup (to get an idea how they can be modified on the fly), you can check the setPIDsForGroup method at https://github.com/robotology/gazebo-yarp-plugins/blob/master/plugins/controlboard/src/ControlBoardDriver.cpp#L256.

@traversaro
Copy link
Member

If we implement this interfaces, we should check the unit of measurement that we are assuming for the gains (see #119 ).

@barbalberto barbalberto added this to the IFI Day 3 milestone Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants