Skip to content

Commit

Permalink
Revert upstream PR 690
Browse files Browse the repository at this point in the history
It causes a performance regression when contacts are involved
  • Loading branch information
diegoferigo committed Sep 29, 2021
1 parent 44b1e0b commit 5c5a527
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions scenario/src/plugins/Physics/Physics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -454,20 +454,16 @@ class ignition::gazebo::systems::PhysicsPrivate
/// \brief Feature list to handle collisions.
public: struct CollisionFeatureList : ignition::physics::FeatureList<
MinimumFeatureList,
ignition::physics::GetContactsFromLastStepFeature,
ignition::physics::sdf::ConstructSdfCollision>{};

/// \brief Feature list to handle contacts information.
public: struct ContactFeatureList : ignition::physics::FeatureList<
CollisionFeatureList,
ignition::physics::GetContactsFromLastStepFeature>{};

/// \brief Collision type with collision features.
public: using ShapePtrType = ignition::physics::ShapePtr<
ignition::physics::FeaturePolicy3d, CollisionFeatureList>;

/// \brief World type with just the minimum features. Non-pointer.
public: using WorldShapeType = ignition::physics::World<
ignition::physics::FeaturePolicy3d, ContactFeatureList>;
ignition::physics::FeaturePolicy3d, CollisionFeatureList>;

//////////////////////////////////////////////////
// Collision filtering with bitmasks
Expand Down Expand Up @@ -551,7 +547,6 @@ class ignition::gazebo::systems::PhysicsPrivate
physics::World,
MinimumFeatureList,
CollisionFeatureList,
ContactFeatureList,
NestedModelFeatureList,
CollisionDetectorFeatureList,
SolverFeatureList>;
Expand Down Expand Up @@ -603,7 +598,6 @@ class ignition::gazebo::systems::PhysicsPrivate
public: using EntityCollisionMap = EntityFeatureMap3d<
physics::Shape,
CollisionFeatureList,
ContactFeatureList,
CollisionMaskFeatureList,
FrictionPyramidSlipComplianceFeatureList
>;
Expand Down Expand Up @@ -3130,7 +3124,7 @@ void PhysicsPrivate::UpdateCollisions(EntityComponentManager &_ecm)
}

auto worldCollisionFeature =
this->entityWorldMap.EntityCast<ContactFeatureList>(worldEntity);
this->entityWorldMap.EntityCast<CollisionFeatureList>(worldEntity);
if (!worldCollisionFeature)
{
static bool informed{false};
Expand Down

0 comments on commit 5c5a527

Please sign in to comment.