Delete grabberDual references #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pattacini
requested changes
Apr 5, 2023
There was a problem hiding this comment.
Thanks @martinaxgloria 👍🏻
Could you:
- Sign the CLA?
- Address the inline comment?
| @@ -4,7 +4,12 @@ | |||
| </dependencies> | |||
| <module> | |||
| <name>yarpdev</name> | |||
| <parameters> --from camera/ServerGrabberDualDragon.ini --split true</parameters> | |||
| <parameters> --from camera/dragonfly2_config_left.ini --split true</parameters> | |||
There was a problem hiding this comment.
The parameter --split true should be meaningful only with the dual driver.
@Nicogene, could you confirm this?
If confirmed, we ought to remove it.
There was a problem hiding this comment.
Yes I confirm it is obsolete 👍🏻
Nicogene
approved these changes
Apr 6, 2023
pattacini
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #469, this PR aims to delete the
grabberDualreferences already present in icub-main.