Calibration type 14 update on calibration value parser #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pattacini
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Hi @MSECode
I guess this is a sister PR of robotology/icub-firmware-shared#83.
You need to:
- Handle the versioning correctly (you may ask @valegagge).
- Sign up for the CLA here below.
- Keep this PR in draft until the one in
icub-firmware-sharedgets merged in order to make CI work as intended.
pattacini
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Hi @MSECode
I guess this is a sister PR of robotology/icub-firmware-shared#83.
You need to:
- Handle the versioning correctly (you may ask @valegagge).
- Sign up for the CLA here below.
- Keep this PR in draft until the one in
icub-firmware-sharedgets merged in order to make CI work as intended.
|
Also, please fill in the body of the PR. |
marcoaccame
approved these changes
Jun 6, 2023
|
We're still missing the version check for |
Remove change rotation to enum and add check of double value Update check of rotation param using enum type Fix error in if clause Update required icub_firmware_shared_VERSION in conf Add check on invertdirection value (must be bolean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings an update to the current version of
calibration type 14. Specifically the following things have changed:CALIBRATIONgroup in thePOSservice configuration file but the final correct values should be defined atparameters 3, 4 and 5of the calibration configuration file as defined in the documentation. Moreover in this fileoffsetandrotationvalues should be passed inicubDegrees.CALIBRATIONgroup in MC and POS is still kept for debugging reasons. Values in calibrators will override the one configured initially by the POS service.icub-mainandicub-firmwarecalib.params.type14.invertdirectionvalue, which must be a boolean value