Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xsens root_link imu configuration file in order to publish correctly with iCubGazeboV2_7 #246

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

martinaxgloria
Copy link
Collaborator

This PR fixes #245

The updates introduced with #231 don't affect the xsens on the root link. This causes errors when iCubGazeboV2_7 model is loaded on gazebo:

[ERROR] |yarp.os.YarpPluginSettings| Cannot find "inertial" plugin (not built in, and no .ini file found for it)Check that YARP_DATA_DIRS leads to at least one directory with plugins/inertial.ini or share/yarp/plugins/inertial.ini in it
[ERROR] |yarp.dev.PolyDriver|inertial| Could not find device <inertial>
[ERROR] GazeboYarpIMU Plugin Load failed: error in opening yarp driver

@traversaro
Copy link
Member

Thanks @martinaxgloria ! Are you sure that this PR fixes #245 ? In particular, it is not clear to me how the measure of the IMU is published for the xsens root_link IMU in this case.

@martinaxgloria
Copy link
Collaborator Author

martinaxgloria commented Aug 31, 2023

Sorry @traversaro, I mean that with these changes the errors mentioned above disappear. I attach here the log:

@@ -29,7 +29,6 @@

<!-- INERTIAL SENSOR-->
<xi:include href="wrappers/inertials/head-inertials_wrapper.xml" />
<!-- NOT USED RIGHT NOW
<xi:include href="wrappers/inertials/waist-inertials_wrapper.xml" /> -->
<xi:include href="wrappers/inertials/waist-inertials_wrapper.xml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is not breaking the simulation for models that are not 2.7 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice catch I didn't notice it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I will restore it

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the wrapper for xsens imu

Restore icub.xml
@martinaxgloria
Copy link
Collaborator Author

As a workaround, @Nicogene proposed to do the changes reported in 1730860.
I tried to launch in Gazebo both iCubGazeboV2_5 and V2_7 and it seems to work.

cc @traversaro @Nicogene

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we can use the subdevice clause I think it is a good compromise

@traversaro
Copy link
Member

Did you try if this is actually working? I am afraid we are hardcoding inertial in gazebo-yarp-plugins .

@traversaro
Copy link
Member

traversaro commented Sep 1, 2023

Did you try if this is actually working? I am afraid we are hardcoding inertial in gazebo-yarp-plugins .

Actually, we should be good to go : https://github.com/robotology/gazebo-yarp-plugins/blob/0fd9300b583267c7bff4fb2be7fe82700ddeb613/plugins/imu/src/IMU.cc#L98 , but perhaps we should put this in the WRAPPER group?

@Nicogene
Copy link
Member

Nicogene commented Sep 1, 2023

Did you try if this is actually working? I am afraid we are hardcoding inertial in gazebo-yarp-plugins .

Actually, we should be good to go : robotology/gazebo-yarp-plugins@0fd9300/plugins/imu/src/IMU.cc#L98 , but perhaps we should put this in the WRAPPER group?

Maybe we need to set disableImplicitWrapper?

@martinaxgloria
Copy link
Collaborator Author

Actually, we should be good to go : https://github.com/robotology/gazebo-yarp-plugins/blob/0fd9300b583267c7bff4fb2be7fe82700ddeb613/plugins/imu/src/IMU.cc#L98 , but perhaps we should put this in the WRAPPER group?

Actually, this warning message is printed out but it doesn't cause the yarprobotinterface to close. I attach here the log:

iCubGazeboV2_7.log

And xsens data were published correctly on the port.

@traversaro
Copy link
Member

Perfect!

@traversaro traversaro merged commit 98d0ff6 into robotology:master Sep 1, 2023
1 check passed
@traversaro
Copy link
Member

I opened #247 to track a proper solution.

@martinaxgloria martinaxgloria deleted the fix/xsens_imu branch September 1, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iCubGazeboV2_7: xsens root_link IMU not published correctly
3 participants