Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1137 #1139

Merged
Merged

Conversation

mebbaid
Copy link
Contributor

@mebbaid mebbaid commented Jan 9, 2024

This PR handles limitations imposed by Irrlicht on the number of vertices per rendered mesh.
Related issue #1137

@S-Dafarra
Copy link
Contributor

I think there might be an issue with assimp on Windows

LINK : fatal error LNK1181: cannot open input file 'assimp.lib' [D:\a\idyntree\idyntree\build\src\visualization\idyntree-visualization.vcxproj]

@traversaro
Copy link
Member

I think there might be an issue with assimp on Windows

LINK : fatal error LNK1181: cannot open input file 'assimp.lib' [D:\a\idyntree\idyntree\build\src\visualization\idyntree-visualization.vcxproj]

I guess this will be fixed by https://github.com/robotology/idyntree/pull/1139/files#r1446594328 .

@traversaro
Copy link
Member

traversaro commented Jan 9, 2024

Thanks a lot for the great work @mebbaid @S-Dafarra !

It is not a big problem in this case, but in the future if you could avoid making big whitespace/indent changes like the one in 2b644e9 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

In the merge, can I squash together the commits? Thanks!

link simply against assimp::assimp

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@mebbaid
Copy link
Contributor Author

mebbaid commented Jan 9, 2024

but in the future if you could avoid making big whitespace/indent changes like the one in 2b644e9 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

yeah, i relied too much on vscode for formating. But should pay attention to that.

In the merge, can I squash together the commits? Thanks!

yeah, thanks a lot!

@traversaro
Copy link
Member

but in the future if you could avoid making big whitespace/indent changes like the one in 2b644e9 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

yeah, i relied too much on vscode for formating. But should pay attention to that.

It is partially fault of iDynTree itself, we should just add a .clang-format file and live happy.

@traversaro traversaro merged commit 295750a into robotology:master Jan 9, 2024
18 checks passed
@mebbaid mebbaid deleted the mebbaid_fork/fix_irrlichtRenderLimit branch January 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants