Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate creation of Model from Python bindings #1160

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

S-Dafarra
Copy link
Contributor

This PR does the following:

  • add some setter methods to ease the setting of the model visual solid shapes from the bindings
  • removed the use of double& when setting the limits and the friction of a joint, as the values were effectively copied
  • bumped the version (as the API has changed)
  • removed some whitespace and included Visual Studio files in the gitignore

@traversaro
Copy link
Member

Thanks! I will bump the major version as for iDynTree I do the exercise of keeping ABI compatibility in major versions (mainly to simplify conda packaging). Other then that it seems great, thanks. cc @francesco-romano any opinion on this? I guess this should not interfere with the pybind11 bindings, but anyhow you may want to have a look.

CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro merged commit 7848e8a into master Mar 8, 2024
39 checks passed
@traversaro traversaro deleted the model_solid_shapes_setters branch March 8, 2024 18:57
@francesco-romano
Copy link
Collaborator

Yes it should not change anything on PyBind11.

Good changes. At some point you should start thinking about removing those new and delete and start using unique_ptr. iDynTree would benefit a lot from that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants