Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new api: getDualSolution #25

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

chibi314
Copy link
Contributor

Sorry for being late.
This PR is related to #21

@GiulioRomualdi GiulioRomualdi changed the base branch from master to devel May 21, 2019 14:43
@S-Dafarra S-Dafarra self-requested a review July 12, 2019 15:11
Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you! If @GiulioRomualdi agrees we can merge!

Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chibi314 for the PR. just a minor comment before merging

include/OsqpEigen/Solver.hpp Outdated Show resolved Hide resolved
@chibi314
Copy link
Contributor Author

@GiulioRomualdi
I reflected your suggestion.

@chibi314
Copy link
Contributor Author

Sorry, I rebased master into this branch by mistake.
Currently it's fixed. (rebased devel branch)

@chibi314
Copy link
Contributor Author

The Travis build faild.
I think that's because devel is not tracking master correctly.

@GiulioRomualdi GiulioRomualdi merged commit 0081d95 into robotology:devel Oct 28, 2019
@chibi314 chibi314 mentioned this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants