-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving yarp middleware plugin to yarp repository #55
Comments
I think it is a good solution. I don't see problems with it. |
@valegagge has a Yarp middleware specific utility library within RTF. At my first check I do not see any problem with moving them to YARP. @valegagge would you please confirm? |
The only issue I foresee is that at the moment, in order to ensure that the library is available, you have to run something like: find_package(RTF COMPONENTS YARP REQUIRED) # Checks if `RTF` is available, and if it was built with the `YARP` component. If we want to keep using this, we need to do some sort of hack in RTFConfig.cmake. I think it is doable, but it will require some more effort, and I don't think it is worth. The alternative is to do the opposite, i.e. something like: find_package(RTF REQUIRED) # Checks if `RTF` is available
find_package(YARP COMPONENTS RTF REQUIRED) # Checks if `YARP` is available, and if it was built with the `RTF` component. Does this look ok to you? |
@apaikan : yes! |
sorry guys, I'm a bit lost... 😳
I can't find a yarp plugin inside |
The mentioned plugin is the hook that RTF uses to work with YARP. RTF is by itself middleware independent so you can use it with yarp, ros or whatever, as long as a plugin is provided for the specified middleware. Right now this plugin is inside RTF repo (I don't remember where), and for this reason we cannot write tests inside yarp harness_xxx using RTF, because yarp will depend on RTF which, in turns, depends on yarp. About which test shall be in harness and which shall use RTF, I share my personal idea:
In my personal account I started a repo because I'm gonna write some tests for the clock and I need a lot of modules to be started (a clock producer, different consumers) and I want to test it also with ROS so I need RTF. I started there because, for the plugin reason, I could not start RTF tests in yarp. Hope it helps |
Fixed in robotology/yarp#1097 . |
For now, yarp middleware plugin in RTF depends on yarp. This means that that it will be very complicated to use RTF to develop units tests within yarp simply because of mutual dependency!
1) The solution suggested by @drdanz is to move the RTF yarp middleware plugin to the yarp repository. In this way one can:
make tests
)2) The second option is to have the yarp unit tests in a separate repository. This needs a bit of more work to compile and run the tests especially if we want to run the new tests (i.e. written using RTF) along with the available tests in YARP.
The text was updated successfully, but these errors were encountered: