Add target_include_directories and rtf_add_plugin #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
changed the title
traversaro
approved these changes
Oct 5, 2017
There was a problem hiding this comment.
In general it is ok, but it would be good to avoid having public properties set on exectuable. Furthermore, it would be good to cleanup the existing macros for adding plugins : https://github.com/robotology/robot-testing/blob/master/conf/RTFTestHelpers.cmake#L30 .
src/testrunner/CMakeLists.txt
Outdated
| @@ -32,6 +32,11 @@ source_group("Header Files" FILES ${folder_header}) | |||
| add_executable(${PROJECT_NAME} ${folder_source} ${folder_header}) | |||
| target_link_libraries(${PROJECT_NAME} ${RTF_LIBS} ${RTF_INTERNAL_LIBS} ${TinyXML_LIBRARIES}) | |||
|
|
|||
| target_compile_features(${PROJECT_NAME} PUBLIC cxx_nullptr) | |||
|
|
|||
| target_include_directories(${PROJECT_NAME} PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | |||
There was a problem hiding this comment.
Not a big problem, but it is a bit strange to have PUBLIC include directories/compile features for an executable.
1 similar comment
1 similar comment
|
merged thanks! |
|
My bad, the existing macros are just to add internal tests of RTF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
add target_include_directoriesandcxx11 target_compile featuresinRTF_dllRTF_rubyRTF_luaRTF_python.Moreover it adds the
cmakemacrortf_add_plugin.Please review code.