Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ergoCubSN001] Change the version of the BAT and BMS #634

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Mar 26, 2024

I found these files uncommitted on the robot. I think they are important.

cc @MSECode @traversaro @pattacini

@traversaro
Copy link
Member

cc @valegagge

@MSECode
Copy link
Contributor

MSECode commented Mar 26, 2024

Hi @GiulioRomualdi,
I think the version should be aligned with what defined in the firmware info file at these lines: https://github.com/robotology/icub-firmware-build/blob/fb6d2150403efcae8ffede9e8887a5473997e2df/info/firmware.info.xml#L48-L49
It is possible to set all zeros to the versions in order to skip the checks about the matching between what defined in the conf and what running on the board at the YRI startup. I think we should set the version as the one running on the board, i.e. 1.3.3, however I suppose that this check is not done by the sw for those 2 CAN boards since they are not able to respond to a "discovery" request made by the ETH boards connected
Anyways, is the YRI rising any error flags complaining about the version mismatch?

@pattacini
Copy link
Member

Hi @MSECode

It is possible to set all zeros to the versions in order to skip the checks about the matching between what defined in the conf and what running on the board at the YRI startup but I'm not sure if it is the best practice to use. I think we should set the version as the one running on the board, i.e. 1.3.3.

We recently decided to drop this versioning done inside the XML files because it is barely maintainable.
New developments on the FW side will compensate for this.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSECode
Copy link
Contributor

MSECode commented Mar 26, 2024

Hi @MSECode

It is possible to set all zeros to the versions in order to skip the checks about the matching between what defined in the conf and what running on the board at the YRI startup but I'm not sure if it is the best practice to use. I think we should set the version as the one running on the board, i.e. 1.3.3.

We recently decided to drop this versioning done inside the XML files because it is barely maintainable. New developments on the FW side will compensate for this.

Oks, good to know. I did not know about that. So I think it's all good with that PR and thanks @GiulioRomualdi

@pattacini pattacini merged commit 27a519e into robotology:devel Mar 26, 2024
1 check passed
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants