Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ft sensor frames #53

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Export ft sensor frames #53

merged 2 commits into from
Dec 21, 2022

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Dec 16, 2022 •
edited
Loading

This PR re-enable the exportation of the ft frames, the name exported is exportedFrameName, if not defined the first fallback is sensorName, if even sensorName is not defined it is exported with jointName name.

If exportFrameInURDF is set to Yes linkName and frameName are mandatory.

It fixes #52

@Nicogene Nicogene marked this pull request as ready for review December 19, 2022 10:38
@Nicogene Nicogene self-assigned this Dec 19, 2022
Nicogene added a commit to robotology/icub-models-generator that referenced this pull request Dec 19, 2022
@Nicogene
icub3: add ROS2 nws
4b7f077 
it requires robotology/simmechanics-to-urdf#53
@Nicogene Nicogene mentioned this pull request Dec 19, 2022
Merged
@traversaro
Copy link
Member

@Nicogene is this ready for review? For the future, it would be great to split the whitespaces changes and the actual logic changes in two different commits, to simplify review.

traversaro
traversaro reviewed Dec 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@traversaro
Copy link
Member

Can you update the CHANGELOG file? Thanks!

@Nicogene
Copy link
Member Author

Nicogene commented Dec 20, 2022 •
edited
Loading

@Nicogene is this ready for review? For the future, it would be great to split the whitespaces changes and the actual logic changes in two different commits, to simplify review.

Yes it is ready 👍🏻

You are right, I did git commit -am and I didn't noticed that vs code saving the file removed also the trailing whitespace

@traversaro traversaro merged commit 30ceec8 into master Dec 21, 2022
@Nicogene Nicogene deleted the exportFtFrames branch December 21, 2022 10:42
@Nicogene Nicogene mentioned this pull request Jan 19, 2023
Merged
@Nicogene Nicogene mentioned this pull request Jun 23, 2023
Merged
@Nicogene Nicogene mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forceTorqueSensors does not export the frame also if exportFrameInURDF is set to true
2 participants
@Nicogene @traversaro