Leonid: readme updates; minor effort refactoring #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Leonid-98
commented
Feb 19, 2024
Leonid-98
commented
- Added documentation
- Changed effort to duty cycle
added 2 commits
February 20, 2024 00:22
Veix123
requested changes
Feb 24, 2024
|
|
||
| In the same format You can also send data to the mainboard to set the motor speeds (from -100 to 100). | ||
| (\*) *All speed units are arbitrary in range (-100:100).* </br> |
There was a problem hiding this comment.
Needs attention. For 'RS' and 'MS' the speed should be in standard units of m/s. For 'RS' it has to be in the Robot's coordinates and for 'MS' it should be the linear speed of the wheel along the axis perpendicular to the motor shaft.
We should clearly note that in 'DC' mode, velocity controllers are disabled and the values are directly set as PWM signal duty cycles for each motor.
There was a problem hiding this comment.
PID will have to be re-tuned.
I will figure this out, but it takes a bit of time.
There was a problem hiding this comment.
moved this to a separate issue to accept other changes now #19
Veix123
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.