Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rosbridge v2 protocol specification: unadvertise #37

Closed
qiuzhong opened this issue Jan 25, 2018 · 1 comment
Closed

rosbridge v2 protocol specification: unadvertise #37

qiuzhong opened this issue Jan 25, 2018 · 1 comment
Assignees
@minggangw

Comments

@qiuzhong
Copy link
Collaborator

According to the rosbridge v2 protocol specification section 3.4.2 unadvertise:

If the topic does not exist, a warning status message is sent and this message is dropped

Test case:

Message: '{"op": "unadvertise", "id": "not_exist_topic_unadvertise", "topic": "not_exist_topic", "type": "std_msgs/String"}'
Expected: warning status message
Actual: {"op":"set_level","level":"none"}
@minggangw minggangw self-assigned this Jan 25, 2018
minggangw pushed a commit to minggangw/ros2bridge_suite-experiment that referenced this issue Feb 2, 2018
Return warning when the unadvertised topic does not exist
9b32ad5 
To align with the rosbridge v2 protocol:

- If the topic does not exist, a warning status message is sent and this
  message is dropped.

This patch implements this logic.

Fix RobotWebTools#37
@minggangw minggangw mentioned this issue Feb 2, 2018
Merged
minggangw pushed a commit to minggangw/ros2bridge_suite-experiment that referenced this issue Feb 5, 2018
Return warning when the unadvertised topic does not exist
2b61352 
To align with the rosbridge v2 protocol:

- If the topic does not exist, a warning status message is sent and this
  message is dropped.

This patch implements this logic.

Fix RobotWebTools#37
@qiuzhong
Copy link
Collaborator Author

qiuzhong commented Feb 6, 2018

Verified as in PR43 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minggangw minggangw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minggangw @qiuzhong