Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main: various height calc changes and footer extension #355

Conversation

REJack
Copy link
Contributor

@REJack REJack commented Mar 26, 2024

  • add drawerFooter additional to footer
  • wrap drawer-content around main content to work with drawerFooter
  • fix sidebar height calculation min-h-screen withoutNav, min-h-[calc(100vh-73px)]
  • remove sidebar padding due too much space at end

- add drawerFooter additional to footer
- wrap drawer-content around main content to work with drawerFooter
- fix sidebar height calculation
  min-h-screen withoutNav, min-h-[calc(100vh-73px)]
- remove sidebar padding due too much space at end
@robsontenorio
Copy link
Owner

Have you tested this on a fresh Laravel project ? No starter kits.

maryUI ships a default layout when installed on fresh projects.

Please, make sure nothing has broken. Compare with current layout version. Because , sidebar toggle is very trick and we don’t want breaking changes for now.

@REJack
Copy link
Contributor Author

REJack commented Mar 27, 2024

I will run the tests soon with a clean laravel project.

@robsontenorio
Copy link
Owner

robsontenorio commented Mar 27, 2024

Also try to resize the window vertically. The current version handles the "collapse button" positioning perfectly.

It was painful to make it work. So, be careful on what you change hahaha 😄

@REJack
Copy link
Contributor Author

REJack commented Mar 27, 2024

I can manage collapsing stuff like that 🤣, I maintained a bigger bootstrap admin theme 😄

@robsontenorio
Copy link
Owner

Thank you! Solved by #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants