Menu item route param, default theme based on system preferences #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added default theme based on system preferences on alpine present plugin.
Don't why there is 2 params as $light and $dark that i don't see used anywhere.
For route param, this simply fixes my use case, where i have whole user panel under same prefix, and it makes few menu items active at the same time, simply using laravel based request()->routeIs() with * sign you can make only few route available.
Third thing is that i changed classes for sidebar to make it without scroll on sidebar. That the only thing that I'm not 100% sure of. But from my testing everything works great, even with bigger menus.