Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate AtriumErrorSpec from spek to kotest #1196

Closed
2 tasks
robstoll opened this issue Oct 5, 2022 · 1 comment · Fixed by #1228
Closed
2 tasks

migrate AtriumErrorSpec from spek to kotest #1196

robstoll opened this issue Oct 5, 2022 · 1 comment · Fixed by #1228
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 5, 2022

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

We want to move away from spek as it's future regarding maintenance and development is quite unsure.
As I don't want to loose hierarchical test setup I decided that we go with kotest

Following the things you need to do:

  • add dependency to kotest in misc/atrium-specs/build.gradle.kts
  • rewrite atrium-core/src/commonTest/kotlin/ch/tutteli/atrium/reporting/AtriumErrorSpec.kt to kotest extending a DescribeSpec

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@jakubriegel
Copy link
Collaborator

I'll work on this

@robstoll robstoll linked a pull request Oct 19, 2022 that will close this issue
@robstoll robstoll added this to the 0.19.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants