Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install v1.2.1 through Homebrew on linux #64

Closed
MrLuje opened this issue Jun 6, 2023 · 6 comments
Closed

Can't install v1.2.1 through Homebrew on linux #64

MrLuje opened this issue Jun 6, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@MrLuje
Copy link

MrLuje commented Jun 6, 2023

Describe the bug
Cannot install krr with homebrew on linux since artifacts have been renamed

To Reproduce
Steps to reproduce the behavior:

  1. brew upgrade krr
    ==> Upgrading 1 outdated package:
    robusta-dev/krr/krr 1.0.0 -> 1.2.1
    ==> Fetching robusta-dev/krr/krr
    Error: krr: Failed to download resource "krr"
    Failure while executing; /usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/4.0.21\ \(Linux\;\ x86_64\ Ubuntu\ 20.04.6\ LTS\)\ curl/7.68.0 --header Accept-Language:\ en --retry 3 --fail --location --silent --head --request GET https://github.com/robusta-dev/krr/releases/download/v1.2.1/krr-linux-latest-v1.2.1.zip exited with 22. Here's the output:
    curl: (22) The requested URL returned error: 404

The issue is with the artifact name on linux which is krr-linux-latest-v1.2.1.zip on brew but krr-ubuntu-latest-v1.2.1.zip on release page

Not sure on which side you want it to be fixed (homebrew vs artifact name)

Expected behavior
Krr should install properly

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows 10 with WSL2
@marcossv9
Copy link

Seeing same issue here, while trying to install krr on Ubuntu 22.04.2 LTS...

brew install krr
==> Fetching robusta-dev/krr/krr
Error: krr: Failed to download resource "krr"
Failure while executing; `/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/4.0.23-2-g0606b63\ \(Linux\;\ x86_64\ Ubuntu\ 22.04.2\ LTS\)\ curl/7.81.0 --header Accept-Language:\ en --retry 3 --fail --location --silent --head --request GET https://github.com/robusta-dev/krr/releases/download/v1.2.1/krr-linux-latest-v1.2.1.zip` exited with 22. Here's the output:
curl: (22) The requested URL returned error: 404
HTTP/2 404 
server: GitHub.com
date: Fri, 16 Jun 2023 18:05:18 GMT
content-type: text/plain; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'
content-length: 9
x-github-request-id: 9C5E:158B:4D1F31:556637:648CA46A

@Avi-Robusta
Copy link
Contributor

HI,
We’re looking into this. In the meantime, you can install from source by the README instructions here:
https://github.com/robusta-dev/krr#manual

@LeaveMyYard LeaveMyYard added the bug Something isn't working label Jun 23, 2023
@Zruto
Copy link

Zruto commented Jun 27, 2023

Have you resolved it ?

@sofiafernandezmoreno
Copy link

sofiafernandezmoreno commented Jul 1, 2023

The problem is here.
It needs replace by
https://github.com/robusta-dev/krr/releases/download/v1.2.1/krr-ubuntu-latest-v1.2.1.zip

You can install in this way:
brew install --build-from-source /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/robusta-dev/homebrew-krr/Formula/krr.rb
where krr.rb is:

class Krr < Formula
    desc "Kubernetes Resource Recommender by Robusta"
    homepage "https://github.com/robusta-dev/krr"
  
    if OS.mac?
        url "https://github.com/robusta-dev/krr/releases/download/v1.2.1/krr-macos-latest-v1.2.1.zip"
        sha256 "f43a992bece07d9ac8ecd6d32524c3225def2ede743971f8e71ab7caa6aafbbb"
    elsif OS.linux?
        url "https://github.com/robusta-dev/krr/releases/download/v1.2.1/krr-ubuntu-latest-v1.2.1.zip"
        sha256 "6fe37a2bb03abe011984de338548c5168afa7a06f82e8252d719fad57943a75c"
    end
  
    def install
        libexec.install Dir["*"]
        bin.write_exec_script (libexec/"krr")
    end
    
    test do
        system "#{bin}/krr", "version"
    end
end
  

@LeaveMyYard
Copy link
Contributor

Update on this issue: we are working on CI/CD issue that causes this (still present on v1.3.2)
Also, a duplicate is created here: #100

@LeaveMyYard
Copy link
Contributor

Closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants