Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolset not in workspace and not runnable from repo root #8

Closed
ScanMountGoat opened this issue Mar 9, 2024 · 1 comment
Closed

Comments

@ScanMountGoat
Copy link

I would like to be able to run the CLI tool with cargo run -p bdat-toolset and check all code with cargo check. I can always cd into the toolset directory, but that creates multiple target directories.

@roccodev
Copy link
Owner

roccodev commented Mar 9, 2024

Gotcha! 854ddfd adds the toolset crate to the workspace.

I was concerned at first about having Cargo.lock in the lib root, but as it turns out, clients ignore it for libraries even if present.

On another note, I'm making some API changes in a separate branch, so some 0.4 features might not work in 0.5. These changes mostly come from my use of the library in Recordkeeper and the enemy compendium, so they boil down to allowing the library to be used more ergonomically with XC3 BDATs (and similarly, older BDATs) at the expense of some conveniences for multi-version support. If you have some other use cases you think the library could be improved for, then please do tell.

@roccodev roccodev closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants