Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support callbacks field so that Flasgger works with OpenAPI 3.0 callbacks #273

Merged
merged 5 commits into from May 4, 2019
Merged

Support callbacks field so that Flasgger works with OpenAPI 3.0 callbacks #273

merged 5 commits into from May 4, 2019

Conversation

jkcdarunday
Copy link
Contributor

Resolves #272

@pep8speaks
Copy link

pep8speaks commented Dec 18, 2018

Hello @jkcdarunday! Thanks for updating the PR.

Line 46:1: E731 do not assign a lambda expression, use a def
Line 47:1: E731 do not assign a lambda expression, use a def
Line 48:1: E731 do not assign a lambda expression, use a def

Comment last updated on December 19, 2018 at 09:55 Hours UTC

@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage increased (+0.06%) to 91.247% when pulling 0507a2a on jkcdarunday:callbacks-field into 37ee864 on rochacbruno:master.

@javabrett
Copy link
Collaborator

@jkcdarunday thanks for the PR.

Would you be able to add a test/example under /examples, and add any helpful doc?

@jkcdarunday
Copy link
Contributor Author

Hi, @javabrett

I have added an example and updated README.md.

@javabrett javabrett self-requested a review December 19, 2018 23:01
@jkcdarunday
Copy link
Contributor Author

Hi @javabrett Is this good now?

Thanks.

@rochacbruno rochacbruno merged commit 6731f0d into flasgger:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

callbacks field for requests not passed for OpenAPI 3.0 docs
5 participants