Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples does not exist #1

Closed
ismay opened this issue Mar 22, 2018 · 2 comments
Closed

samples does not exist #1

ismay opened this issue Mar 22, 2018 · 2 comments

Comments

@ismay
Copy link

ismay commented Mar 22, 2018

It seems that samples does not exist as documented in the readme:

// array of numbers
console.log(wav.samples);

instead, it's available under samples_, and the unit tests seem to only test for the samples_ property as well. Is this an oversight? Should samples not be available under samples and not samples_?

@rochars
Copy link
Owner

rochars commented Mar 23, 2018

"samples_" was renamed to "samples" and "bitDepth_" was renamed to "bitDepth". Thanks.

@ismay
Copy link
Author

ismay commented Mar 23, 2018

Cool, thanks for the quick fix! 👍🎉

@rochars rochars closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants