-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think it would be possible to get an official R stack? #16
Comments
I was thinking about that too. It is appealing but puts more of a burden on to actually carry on with this. Another 'maybe review in a week or two or three...' question? |
Hello. I don't work with R code, but it's clear to me that you guys have created some good Dockerfiles for R, especially with all of the recent hacking (sorry, Docker isn't perfect yet, and we'll get better about documenting the edges!). I would love to see an official R language stack image based on rocker/r-base if you are interested. This would require some up-front work and then a follow-on process of bumping changes via PRs to https://github.com/docker-library/official-images. Looking over the r-base Dockerfile there are just a couple of things which come to mind:
|
@psftw You rock. Thanks for the note. @cboettig and have discussed attempting to be 'official', we just wanted to mature this a little more. So really appreciate you starting the dialogue. Re your comments:
|
Great. I'm not opposed to using debian:testing, though I see you've since switched to jessie. I also see the "littler" stuff was also updated as expected. I'll try to get back to you soon in the other thread (#50). 👍 on the contributing section that was added. It isn't clear to me why you are avoiding PRs to master directly -- do you have a custom build integration with github or something? |
@psftw : Thanks for getting back to us. Reopening the dialogue was on my todo list, but I was at a workshop most of last weekend, and this thing called 'work' gets in the way too. You raise a few distinct issues. Allow me to disentangle them a little:
Dirk |
@psftw Just chatted with @cboettig -- if you are confused about master vs sandbox branches for Rocker: Each commit used to trigger half a dozen builds, and we sometimes committed multiple times a day. But going to sandbox first we are able to throttle and control that. We are approaching calmer times to we may get back to direct commits (and hence PRs) to master. Nothing sinister here. |
Go ahead and switch back to debian:testing if that's what makes sense for you. I haven't read through #50 yet, but I want to make sure I answer any outstanding questions you may have about permissions, etc, hence why I mentioned it. If your reasoning for using sandbox vs master is purely to reduce load on DockerHub build systems, then you are being overly considerate. Sending pull requests directly to master would be a couple of steps easier for contributors who may not be Git experts. It's up to you, I'm agnostic about it. |
@psftw : Please have another look at the current state of Dockerfiles for Rocker, and see if there there are any other outstanding issues. |
Paging @psftw : Any interest? Or comments? |
The r-base image is maintained by the [rocker-org](https://github.com/rocker-org/rocker) project. This would add support for an official container for R, as suggested in rocker-org/rocker#16
I'm happy with the Dockerfile for r-base. Let's continue in the official-images PR. |
Thanks @psftw et al for your help with this. the PR for this issue, docker-library/official-images#310 has now been merged so I think we can close this issue out for now. I guess we may consider proposing an r-devel or rstudio flavor for the official image down the road under a new issue. |
e.g. see http://blog.docker.com/2014/09/docker-hub-official-repos-announcing-language-stacks/
The text was updated successfully, but these errors were encountered: