Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusUpdated is emitted 2 times in the same function with same inputs #222

Open
guybrush opened this issue Aug 24, 2021 · 1 comment
Open

StatusUpdated is emitted 2 times in the same function with same inputs #222

guybrush opened this issue Aug 24, 2021 · 1 comment

Comments

@guybrush
Copy link

StatusUpdated is emitted 2 times here: https://github.com/rocket-pool/rocketpool/blob/bf79937/contracts/contract/minipool/RocketMinipoolDelegate.sol#L191-L207

I think the first emit is unnecessary?

You can see this on the current prater-testnet: https://goerli.etherscan.io/address/0xb6179bef8927ccb96cc0d33a76f379d48ca62142#events
@VGR-GIT
Copy link

VGR-GIT commented Aug 24, 2021

I have notified Kane of this a few days ago. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guybrush @VGR-GIT