Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: UI and Alignment Issues in Video Recorder Modal #455

Closed
Spiral-Memory opened this issue Feb 8, 2024 · 1 comment · Fixed by #456
Closed

[BUG]: UI and Alignment Issues in Video Recorder Modal #455

Spiral-Memory opened this issue Feb 8, 2024 · 1 comment · Fixed by #456
Labels
bug Something isn't working

Comments

@Spiral-Memory
Copy link
Collaborator

Description:

There are small but multiple issues with the video recorder UI:

Steps to reproduce:

  1. Set up the Embedded chat and log in.
  2. Click on the video recorder icon from the toolbar.
  3. Observe the UI issues.

Expected behavior:

The UI should look clean and uniform.

Actual behavior:

  1. The stacking context is not correct. Since it is a modal and is passed as a child to InputFormattingToolbar, which has a lower z-index than the header, the header appears to pop out, which is not appropriate.

  2. Additionally, the alignment of the action button box is incorrect.

  3. There are some unused styling and syntax issues that need attention.

  4. Need some changes in design for clean UI

Screenshot from 2024-02-08 13-35-02

Screenshot from 2024-02-08 13-36-15

@Spiral-Memory Spiral-Memory added the bug Something isn't working label Feb 8, 2024
@Spiral-Memory
Copy link
Collaborator Author

@abhinavkrin , there were some UI issues in the video recorder modal. I have fixed them, the issue was mainly with stacking order which took time to understand and fix this. Additionally made the UI clean and fixed alignment issues. Kindly review the PR to see if everything looks fine or if any necessary changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant