[New feature] Add option to disable BTRFS quota/qgroups #1592
Comments
maxhq
changed the title
|
Adding some note: M. |
|
You both have good points here. Redesigning the quota stuff has been on my list for a while. I see that things have improved in 4.10, but it would be nice to give the option to cleanly disable them. |
|
Linking to related pr #1867 where we at least don't block mounts when quota disabled. |
|
I am currently working on this issue. |
|
Final testing in progress. Pull request to follow shortly. |
|
Inline edit of quotas Enabled / Disabled setting in Pool overview page: |
Adds pool api command to enable / disable quotas. Upon enabling a quota rescan is initiated. In some instances this scan is redundant but is robust to those instances and simply info logs the prior existence of an ongoing quota rescan and skips the rescan requested. Similarly provision is made to deal elegantly with quota rescan requests on read only filesystems. UI is by way of bootstrap inline editable as per current compression and custom mount options settings. Summary: - Add backend pool quota enable/disable command. - Change existing quota status displays for inline editable elements. - Move pool details page quota element from "Details" section to "Compression and extra mount options" section as then all inline edit elements are grouped. - Rename compression / extra mount options header to indicate quotas. - Allowed quotas enable/disable on the system pool.
|
The code to address this issue is now ready, however as it interrelates closely with an existing and outstanding pull request I will await that pull requests review and potential merge prior to submitting the pull request for this issue. Noting ideal dependency on prior merge of pr: "empty compression setting on imported pools blocks extra mount options. Fixes #1896" pr #1899 Once the outcome of the above referenced pull request is finalised I can, if then appropriate, re-base and submit the pr for this issue. This cautionary action is due to many very closely related changes made to the bootstrap inline editable UI code that could lead to merge difficulties if a re-base is not first performed. |
|
This issue is again my main focus and will shortly be rebased, retested, and it's associated pull request submitted. |
|
About to delete GitHub resident branch, re-base, and re-publish under the same branch name. |
Adds pool api command to enable / disable quotas. Upon enabling a quota rescan is initiated. In some instances this scan is redundant but is robust to those instances and simply info logs the prior existence of an ongoing quota rescan and skips the rescan requested. Similarly provision is made to deal elegantly with quota rescan requests on read only filesystems. UI is by way of bootstrap inline editable as per current compression and custom mount options settings. Summary: - Add backend pool quota enable/disable command. - Change existing quota status displays for inline editable elements. - Move pool details page quota element from "Details" section to "Compression and extra mount options" section as then all inline edit elements are grouped. - Rename compression / extra mount options header to indicate quotas. - Allowed quotas enable/disable on the system pool.
|
Really thankful for the work you did on this @phillxnet ! |
…RFS_quota-qgroups Add option to disable BTRFS quota-qgroups. Fixes #1592
|
@schakrava Thanks. Hopefully with ongoing quota work upstream this will in time become less of an issue going forward. |
Qgroups seem to cause a lot of trouble / performance issues. Personally I get errors like
BTRFS warning (device sda): orphan qgroup relation 0x563->0x7df00000000000a.Picking up an idea from a forum post by Matthew it would be nice to be able to completely disable quota related functions in Rockstor.
The text was updated successfully, but these errors were encountered: