Add option to disable BTRFS quota-qgroups. Fixes #1592 #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds pool api command to enable / disable quotas. Upon enabling a quota rescan is initiated. In some instances this scan is redundant but is robust to those instances and simply info logs the prior existence of an ongoing quota rescan and skips the rescan requested. Similarly provision is made to deal elegantly with quota rescan requests on read only filesystems. UI is by way of bootstrap inline editable as per current compression and custom mount options settings. Summary: - Add backend pool quota enable/disable command. - Change existing quota status displays for inline editable elements. - Move pool details page quota element from "Details" section to "Compression and extra mount options" section as then all inline edit elements are grouped. - Rename compression / extra mount options header to indicate quotas. - Allowed quotas enable/disable on the system pool.
schakrava
reviewed
Mar 10, 2018
| # when attempting a rescan. | ||
| # Look similar to https://patchwork.kernel.org/patch/9928635/ | ||
| enable_quota(pool) | ||
| enable_quota(pool) |
There was a problem hiding this comment.
It may be useful to open an issue to keep track of future refactoring of this logic.
There was a problem hiding this comment.
Agreed. I have just created what I think should cover it:
"re-address double enable_quota() call requirement" #1905
|
This is really nice! I am eager to try disabled quotas on our staging boxes and see the performance differences. |
|
@schakrava Thanks. I'll try and revisit the sub optimal double quota thing on the next kernel / btrfs-progs update. I was a little surprised by that behaviour and I'm keen to re-address it as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pool api command to enable / disable quotas. Upon enabling a quota rescan is initiated. In some instances this scan is redundant but is robust to those instances and simply info logs the prior existence of an ongoing quota rescan and skips the rescan requested. Similarly provision is made to deal elegantly with quota rescan requests on read only filesystems. UI is by way of bootstrap inline editable as per current compression and custom mount options settings.
Summary:
Fixes #1592
Additionally as we initiate a rescan upon enabling quotas on a given pool this pr also:
Fixes #1785
@schakrava Ready for review.
This pr represents the enable/disable api and front end to the work done for issue:
"improve quotas not enabled behaviour #1869"
and it's pr:
"improve quotas not enabled behaviour. Fixes #1869" #1874
re quota groups management / recreation through quota disabled / enabled cycles.
Tested in KVM systems and on a number of small real hw installs in the low TB range of pool size.
Caveats / future enhancements: we currently give no indication of ongoing rescans, this could properly be addressed against it's own issue. The consequence of not surfacing an ongoing quota rescan is potential user confusion re share size reporting which will periodically adjust for a number of minutes after re enabling quotas (with quotas disabled shares are reported as taking 0 space (currently)).