Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rockstor Devel Feature] Add Eslint over js files #1629

Closed
MFlyer opened this issue Jan 24, 2017 · 3 comments
Closed

[Rockstor Devel Feature] Add Eslint over js files #1629

MFlyer opened this issue Jan 24, 2017 · 3 comments

Comments

@MFlyer
Copy link
Member

MFlyer commented Jan 24, 2017

No description provided.

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 24, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer
Copy link
Member Author

MFlyer commented Jan 24, 2017

@schakrava @phillxnet & @priyaganti do you agree on this? :)

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 25, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
… config

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
…ed all

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer
Copy link
Member Author

MFlyer commented Jan 26, 2017

Adding django Pipeline ref for js files order

PIPELINE = {
    'DISABLE_WRAPPER': True,
    'JS_COMPRESSOR': None,
    'CSS_COMPRESSOR': None,
    'TEMPLATE_FUNC': 'Handlebars.compile',
    'JAVASCRIPT': {
        'storageadmin': {
            'source_filenames': (
                'storageadmin/js/license.js',
                'storageadmin/js/templates/**/*.jst',
                'storageadmin/js/templates/**/**/*.jst',
                'storageadmin/js/socket_listen.js',
                'storageadmin/js/rockstor.js',
                'storageadmin/js/rockstor_widgets.js',
                'storageadmin/js/rockstor_logger.js',
                'storageadmin/js/paginated_collection.js',
                'storageadmin/js/router.js',
                'storageadmin/js/graph.js',
                'storageadmin/js/d3.slider2.js',
                'storageadmin/js/models/models.js',
                'storageadmin/js/views/common/*.js',
                'storageadmin/js/views/*.js',
                'storageadmin/js/views/pool/**/*.js',
                'storageadmin/js/views/dashboard/*.js',
                ),
            'output_filename': 'storageadmin/js/storageadmin.js'
            },
        }
}

@MFlyer
Copy link
Member Author

MFlyer commented Jan 26, 2017

To @schakrava :
eslint itself need info about our pipeline order, so thinking to have it all via gulp.
gulp.js has eslint plugin and..flake8 too 😄
Having this working can be useful for everyone contributing to Rockstor

Mirko

MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 26, 2017
…rt 1

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer referenced this issue in MFlyer/rockstor-core Jan 26, 2017
eslintrc.js can be improved, but working fine
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 27, 2017
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
MFlyer added a commit to MFlyer/rockstor-core that referenced this issue Jan 27, 2017
… 1900 from 8000

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@MFlyer MFlyer closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant